-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update descriptions in the settings menu #2273
Conversation
I thought these labels could be improved and those describe the relevant sections better IMO, getting more to the point. Native English speakers, please confirm and review! Signed-off-by: Yannick Schaus <github@schaus.net>
Job #1357: Bundle Size — 15.84MiB (~-0.01%).Warning Bundle contains 16 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #1357 report View settings-menu-labels branch activity View project dashboard |
Btw, we have to check why the bundle metrics are like:
I think the baseline hasn't changed since #2063. In any case 300kB more initial JS is a lot in 4 months; we'll have to investigate why it happened. |
@ghys the baseline is the latest job in the default branch at the time of the build. Looks like your latest job in the default branch ( The https://github.com/openhab/openhab-webui/blob/main/.github/workflows/mainui.yml#L3
|
@vio Thx for pointing out what to do. @ghys I have tried to find out what caused the initial CS bundle-size increase, and it is not easy to find out the cause from checking the RelativeCI history, but it seems that #2088 at least lead to some increase. #2253 will help with that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
But I am no native English speaker, so let's ping one @rkoshak.
The english all looks just fine. |
I thought these labels could be improved and those describe the relevant sections better IMO, getting more to the point. Native English speakers, please confirm and review!